cdisc-org / ddf-core-poc

This repository will contain the results from the Proof of Concept project.
MIT License
0 stars 1 forks source link

Create rule: Among the ScheduledTimelines associated with the StudyDesign, no more than one must have the attribute mainTimeline = true #128

Closed ASL-rmarshall closed 8 months ago

ASL-rmarshall commented 8 months ago

Create rule defined for #13

ASL-rmarshall commented 8 months ago

Duplicate of #65

BSnoeijerCD commented 7 months ago

@ASL-rmarshall @gerrycampion I tried the disctinct function but it gave an run error: "error":"An unknown exception has occurred" "message":"'str' object has no attribute 'get'" I tried to omit domain or define it as ScheduleTimeline, ScheduleTimeline.xpt, SCHEDULETIMELINE but that did not help. Not sure if I need to do anything else or that it is just not conforming to non-sdtm data.

See DDF99912 in the rule editor.

gerrycampion commented 7 months ago

@ASL-rmarshall @gerrycampion I tried the disctinct function but it gave an run error: "error":"An unknown exception has occurred" "message":"'str' object has no attribute 'get'" I tried to omit domain or define it as ScheduleTimeline, ScheduleTimeline.xpt, SCHEDULETIMELINE but that did not help. Not sure if I need to do anything else or that it is just not conforming to non-sdtm data.

See DDF99912 in the rule editor.

@BSnoeijerCD when discussing issues like this, can you ensure the test data is also available in sharepoint in the corresponding location so that we can test on our end and reproduce. I took a look at the rule and fixed 2 issues (you can view in the diff history):

After you add the test data to sharepoint, let us know if it still isn't working and I'll take another look.

BSnoeijerCD commented 7 months ago

@ASL-rmarshall @gerrycampion I tried the disctinct function but it gave an run error: "error":"An unknown exception has occurred" "message":"'str' object has no attribute 'get'" I tried to omit domain or define it as ScheduleTimeline, ScheduleTimeline.xpt, SCHEDULETIMELINE but that did not help. Not sure if I need to do anything else or that it is just not conforming to non-sdtm data. See DDF99912 in the rule editor.

@BSnoeijerCD when discussing issues like this, can you ensure the test data is also available in sharepoint in the corresponding location so that we can test on our end and reproduce. I took a look at the rule and fixed 2 issues (you can view in the diff history):

  • Operations value needs to be a list of objects, not a single object.
  • The id had an extra trailing underscore in the definition ($st_parent_id_)

After you add the test data to sharepoint, let us know if it still isn't working and I'll take another look.

Thank you @gerrycampion. It works now and I will upload the test data next time I have an issue.