Closed ASL-rmarshall closed 7 months ago
Rule id updated from DDF99987 to DDF00033.
@DianeWold This one is also ready for review. I created test data as follows:
code.code
value (even though the decodes are different). Both records should be reported as errors.code.code
value (even though the decodes are different). Only the secondary reasons should be reported as errors.code.code
value the the otherReason
values are different. Both records should be reported as errors.code.code
value for "Other", but with different otherReason
values. Only the secondary reasons should be reported as errors.@ASL-rmarshall Should discuss whether the rule needs to be modified.
Negative and positive test data ran as expected.
However, rule may need to be modified to allow multiple instances of the code for "other" if values of otherReason are different.
Also note comment above about checking needed for the same code used for different study amendments.
Agreed that multiple instances of the code "other" should trigger the rule, as in this case otherReason would have to be checked by hand. Comparing otherReason values electronically could easily miss slight representations of the same reason.
@DianeWold and @ASL-rmarshall I would say that reasons can be the same across different amendments. So the check should be within an amendment. Not within a study definition. I cannot see whether this now done based on the Core ruled definition. Not sure whether multiple instances of Other should trigger the rule. Although I agree with your point Diane, I believe the check description text should then be different - indicating that it could be right but should be checked. While twice filling the same reason is really an error.
Saving a copy of the POC rule definition before deleting for DDF 4:
Authorities:
- Organization: 'CDISC'
Standards:
- Name: USDM
References:
- Citations:
- Cited Guidance: 'USDM'
Document: 'USDM v2.6'
Origin: USDM Conformance Rules
Release Notes: ''
Rule Identifier:
Id: 'DDF00033'
Version: '1'
Version: '1.0'
Version: '3.0'
Check:
all:
- name: code.code
operator: is_not_unique_set
value:
- parent_id
Core:
Id: CORE-000425
Status: Draft
Version: '1'
Description: 'For a Study Amendment, the set of codes for StudyAmendmentReason
must not include duplicates.'
Executability: Fully Executable
Outcome:
Message: 'The StudyAmendmentReason codes for a StudyAmendment includes duplicates'
Output Variables:
- parent_entity
- parent_id
- parent_rel
- id
- code.code
- code.decode
- otherReason
Rule Type: Record Data
Scope:
Entities:
Include:
- StudyAmendmentReason
Sensitivity: Record
Create rule defined for #114