cdisc-org / ddf-core-poc

This repository will contain the results from the Proof of Concept project.
MIT License
0 stars 1 forks source link

Create dirty JSON test data #157

Closed DianeWold closed 5 months ago

DianeWold commented 7 months ago

This will be done by editing the "clean" test data, then making changes to trigger existing created rules.

DianeWold commented 7 months ago

Added errors that should trigger the following rules: DDF00005 added a second sponsor identifier DDF00006 removed the lower bound on a window DDF00025 added a window description to an anchor DDF00008 scheduled instance with both a default condition and an exit DDF00013 required BC property not enabled DDF00015 phase not in terminology DDF00020 other study amendment without specified reason DDF00036 anchor not start to start DDF00012 no main timeline DDF00007 anchor with different relative to and relative from links DDF00031 non-anchor with relative to and relative from links the same DDF00033 duplicate study amendment reasons DDF00022 child link to itself DDF00021 three errors, for previous, next, and defaultcondition links to itself DDF00014 two timings with the same label DDF00034 no response code enabled

I did not add errors for the following rules DDF00004 couldn't find an administration duration will vary in the json file DDF00011 complement of DDF00012 couldn't have both no main timeline and two main timelines

DianeWold commented 7 months ago

At one point, my original data file wouldn't save so I made a copy and renamed it Both are here https://cdisc.sharepoint.com/sites/ddf/Shared%20Documents/Forms/AllItems.aspx?id=%2Fsites%2Fddf%2FShared%20Documents%2FDDF3a%2FJsonTestFiles&viewid=9a467a7f%2D5356%2D4249%2D808a%2D07dba21b0b7d I don't seem to be able to save the new copy. Should I delete the old one to make space?

DianeWold commented 7 months ago

Issues with saving the dirty json file resolved. The correct file is the one with "dirty1" in its name.

ASL-rmarshall commented 6 months ago

I have updated the CDISC_Pilot_Study_dirty1.json file in SharePoint with the changes I made to get the command line interface (CLI) to work correctly. Apart from the formatting changes (adding/removing line breaks according to the usual JSON formatting for CDISC repositories - i.e. as applied by the prettier JSON formatter), these are the changes I made: