search

cdisc-org / ddf-core-poc

This repository will contain the results from the Proof of Concept project.
MIT License
0 stars 1 forks source link

Support joining data sets by non-matching key names #91

Closed ASL-rmarshall closed 5 months ago

ASL-rmarshall commented 10 months ago

For DDF checks, we will often need to join datasets by parent_id = id, but Match Datasets currently seems only to handle SDTM-based data set joining (either where the key variable has the same name in the joined datasets, or joining is via the predefined relationship dataset variables).

For now, this should be an implicit join without the need to specify join conditions, since most will be the same. This should do a full outer join to support parents that don't have children and malformed data children that don't have parents

drewcdisc commented 9 months ago

@nickdedonder This is the ticket (PBI) that Gerry thinks should be 2nd in priority for Rule Engine work. It will unblock several rules. The first is PBI #35

RamilCDISC commented 6 months ago

QA validation for the issue is over. The updates successfully implements the desired functionality. The engine now successfully supports joining of datasets by non matching keys.I tested the code for the edge cases too. The system handles them properly. Following screenshot shows successful run of the tests.

91