search

cdisselkoen / llvm-ir

LLVM IR in natural Rust data structures
MIT License
550 stars 46 forks source link

LLVM 12 #11

Closed TheZoq2 closed 3 years ago

TheZoq2 commented 3 years ago

It looks like LLVM 12 was released last month, do you have plans to update this library for it? I'd be happy to help out with the process if you'd like, but I might need some pointers to figure out what needs changing.

Looking at the LLVM-11 update, I suppose one needs to go through the changelog of llvm to find the things that need patching, or is there an easier way?

cdisselkoen commented 3 years ago

Thanks for the ping, yes I do plan to update for LLVM 12. As far as the process, it looks like llvm-sys has already released an LLVM 12 version, so I'll look at their changelog to see if corresponding updates need to be made here, and also I'll look at the general llvm changelog.

cdisselkoen commented 3 years ago

Almost ready to go, but regression tests for the SRet parameter attribute are failing. LLVM 12 changed it from a simple attribute to one that takes an argument, and for some reason the C API seems to be behaving in some way I'm not expecting for it. Will keep investigating.

cdisselkoen commented 3 years ago

Fixed in 071a74f on master and in 2974c0a on 0.7.x. Released as version 0.7.5 on crates.io.

TheZoq2 commented 3 years ago

Awesome, thanks for the quick response :heart: