The `Name` field of `GlobalReference` could be a `String`

cdisselkoen / llvm-ir

LLVM IR in natural Rust data structures

MIT License

539 stars 45 forks source link

The `Name` field of `GlobalReference` could be a `String` #23

Closed langston-barrett closed 1 year ago

langston-barrett commented 1 year ago

The GlobalReference constant has a Name field, where Name is a sum of u64 and String. I believe global variables and functions always have actual names, rather than numbers - perhaps the Name field of GlobalReference could be specialized to String?

cdisselkoen commented 1 year ago

You are right. Let's specialize

cdisselkoen commented 1 year ago

Reverted this after discussion on #42.