cdk-turnkey / brian-liberation

Mad lib Brians.
Apache License 2.0
1 stars 2 forks source link

Delete cookies on logout #18

Open douglasnaphas opened 3 years ago

douglasnaphas commented 3 years ago

As noted in #14, this will help with keeping authenticated flows straight. Port to Mad Liberation to complete https://github.com/douglasnaphas/madliberation/issues/253.

douglasnaphas commented 3 years ago

Reference

  1. Printing cookies in itest (Puppeteer)
  2. Deleting cookies server-side
douglasnaphas commented 3 years ago

I have a failing test in CI, and I need to make application code changes, so now is the time to set up inter-commit deployment.

douglasnaphas commented 3 years ago

I'm able to do an inter-commit deploy of backend with:

STACKNAME=$(GITHUB_REPOSITORY=douglasnaphas/brian-liberation GITHUB_REF=refs/heads/18-logout npx @cdk-turnkey/stackname@1.2.0 --suffix webapp)

and then, in the same shell:

time GITHUB_REPOSITORY=douglasnaphas/brian-liberation GITHUB_REF=refs/heads/18-logout AWS_PROFILE=doug AWS_REGION=us-east-1 npx cdk deploy ${STACKNAME}

time is prepended for a report of how long the whole process takes, which is 1 minute 21 seconds for an inter-commit deploy:


real    1m21.086s
user    0m16.668s
sys     0m6.327s