search

cdk / depict

SMILES Depiction Generator
GNU Lesser General Public License v2.1
54 stars 14 forks source link

Correct Docker invocation and dep updates #46

Closed mjw99 closed 1 year ago

johnmay commented 1 year ago

Thanks will be a release soon updating to CDK 2.8, have it locally and testing

mjw99 commented 1 year ago

I was also considering switching the image to use the JRE from eclipse-temurin:17-jre-alpine

johnmay commented 1 year ago

whats the size diff?

mjw99 commented 1 year ago

I think around 80M bigger

johnmay commented 1 year ago

Will look into it

johnmay commented 1 year ago

+80MB is more than double the size right?

johnmay commented 1 year ago

What's the advantage of termurin? Why not openjdk:17-alpine

mjw99 commented 1 year ago

+80MB is more than double the size right?

Yes:

$ docker images | grep jre
eclipse-temurin   17-jre-alpine      cabdba77eafb   3 weeks ago    168MB
openjdk           8u212-jre-alpine   f7a292bbb70c   3 years ago    84.9MB

What's the advantage of termurin? Why not openjdk:17-alpine

I think support is being wound down for openjdk docker images: https://github.com/docker-library/openjdk/issues/505

johnmay commented 1 year ago

good to bump for next release