search

cdk / depict

SMILES Depiction Generator
GNU Lesser General Public License v2.1
54 stars 14 forks source link

feat: include maven in docker build, allow nonroot users of container. #47

Closed C-nit closed 1 year ago

C-nit commented 1 year ago

Hi!

I wanted to quickly rebuilt the docker image and saw the instructions require the jar file to be available locally. The download of that doesn't work by the way.

In the PR I replace the Dockerfile with one where the maven build is done in Docker as a previous step. This should not affect the size of the image. I also added a different directory to not have stuff in the root directory, giving it permissions per best practices.

I left a dev version of the Dockerfile that works with the build.sh to keep the option to use local jar files.

johnmay commented 1 year ago

Fixed the download link, likely because I split out the lib part. Changes look reasonable, why keep the Dockerfile_dev? I'm happy to just remove that, not seen the builder syntax before.

I will try and find time this week to check all working OK but I have no objection to the changes.