search

cdk / depict

SMILES Depiction Generator
GNU Lesser General Public License v2.1
54 stars 14 forks source link

Build broken - centres-cdk not in maven repo? #6

Closed tdudgeon closed 6 years ago

tdudgeon commented 6 years ago

The build seems broken at the moment (both on master and the 0.3 tag). It's failing because if can't find com.simolecule:centres-cdk:jar in the maven repo, and indeed that artifact does not seem to be in the OSSRH or Maven Central repos.

[ERROR] Failed to execute goal on project cdkdepict: Could not resolve dependencies for project org.openscience.cdk:cdkdepict:war:0.3: Could not find artifact com.simolecule:centres-cdk:jar:0.1-SNAPSHOT in OSSRH (https://oss.sonatype.org/content/repositories/snapshots) -> [Help 1]

johnmay commented 6 years ago

For now you need to install centres separately. 

git clone https://github.com/SiMolecule/centres && cd centres && mvn install -DskipTests
johnmay commented 6 years ago

I'll try and find time to put it on OSSRH this week though.

johnmay commented 6 years ago

Done, also pushed to docker hub

docker run -p 8081:8080 simolecule/cdkdepict

tdudgeon commented 6 years ago

Not sure this is sorted yet. The depict app is looking for is com.simolecule:centres-cdk:jar:0.1-SNAPSHOT but it looks like the artifacts can be found under:

https://oss.sonatype.org/content/repositories/snapshots/com/simolecule/centres/centres-cdk/0.1-SNAPSHOT/

(note the extra centres in the path).

For me I still get this error when trying to do a mvn assemble on master or 0.3 tag:

[ERROR] Failed to execute goal on project cdkdepict: Could not resolve dependencies for project org.openscience.cdk:cdkdepict:war:0.3: Could not find artifact com.simolecule:centres-cdk:jar:0.1-SNAPSHOT in OSSRH (https://oss.sonatype.org/content/repositories/snapshots) -> [Help 1]

e.g. if you change the pom.xml to to contain this: <groupId>com.simolecule.centres</groupId> the build goes OK, but this may not be the correct fix.

johnmay commented 6 years ago

Sorry yes, that is the correct fix. I had to change the group id for deploying to maven central and forgot to update it here.

tdudgeon commented 6 years ago

Thanks for the fix John. Works OK for me now.