search

cdk / depict

SMILES Depiction Generator
GNU Lesser General Public License v2.1
54 stars 14 forks source link

Migrate docker image from deprecated openjdk to eclipse-temurin #64

Closed mjw99 closed 1 year ago

johnmay commented 1 year ago

Thanks

johnmay commented 1 year ago

Does it make sense to update the build container as well?

mjw99 commented 1 year ago

I am not sure if the eclipse-temurin:8u352-b08-jre-alpine container has maven in or any of the compiler bits. I had been just focusing on the security aspect of the runtime image; i.e. it was quite old.

Also, thinking this over, it might be better to specify the runtime in a more generic way, i.e. "eclipse-temurin:8-jre-alpine" so that the latest version is always pulled at build time.

johnmay commented 1 year ago

I'm happy with whatever, you suggest. TBH using JDK/JRE 17 is fine here as well - nice to have the option to build for 8 but I tend to use 17 where possible.