search

cdk8s-team / cdk8s-cli

Apache License 2.0
38 stars 23 forks source link

Import gets stuck importing CRD file for Emissary Ingress #2338

Open alexbowers opened 1 year ago

alexbowers commented 1 year ago

Description of the bug:

When trying to import Emissary Ingress as a CRD, it gets stuck; likely because the CRD file also includes "normal" resources, such as Namespace, etc as well as CRDs.

There is also full --- yaml sections which are just comments. Potentially this could cause the issue also

Reproduction Steps:

Import https://app.getambassador.io/yaml/emissary/3.7.2/emissary-crds.yaml

This is :bug: Bug Report

alexbowers commented 10 months ago

Hi, I'm happy to take a look at this during Hacktoberfest if anybody can give me some pointers on what they think the solution and / or cause might be?

iliapolo commented 3 months ago

Freaky. The file is definitely not something we can consume with cdk8s import because it contains resource declaration, not just CRDs. cdk8s import is for code generation based on a schema, it does not generate a manifest, so there's nothing it can do with resource declarations.

I'm not sure this is the reason it gets stuck, there might nome some circular references going on here. Needs research. In any case we should not get stuck, we should either error out, or ignore whatever is reasonable to ignore and complete the operation.