search

cdk8s-team / cdk8s-plus

A software development framework that provides high level abstractions for authoring Kubernetes applications.
https://cdk8s.io/docs/latest/plus/
Apache License 2.0
133 stars 33 forks source link

Allow specifying multiple `dockerRegistryAuth`s. #3524

Open HamishWHC opened 8 months ago

HamishWHC commented 8 months ago

Description of the feature or enhancement:

Currently, only a single secret for registry auth is accepted when creating a pod/deployment. The K8s spec allows for mutiple to be specified, so that we can pull images from multiple sources if needed.

Use Case:

I need my pods to include a container from my own registry plus a sidecar from a public registry.

Proposed Solution:

Unsure how best to make a change like this - not all the supported languages allow for args to be multiple types like in TS or Python AFAIK (in those languages you could just allow ISecret | ISecret[]/Python equivalent to avoid breaking existing code), so potentially adding a new property? Seems clunky though.

Other:

This is a :rocket: Feature Request

iliapolo commented 3 months ago

Yeah this unfortunate, but a new property/method would be required to avoid a breaking change. Still ok.