cdklabs / aws-delivlib

setup and manage continuous delivery pipelines for code libraries in multiple languages
Apache License 2.0
375 stars 35 forks source link

chore: update binaries in layer zips #1703

Closed scanlonp closed 3 months ago

scanlonp commented 3 months ago

Steps to create this PR:

  1. Download and unzip current zip files
  2. Create a new EC2 instance (Amazon Linux 2023 AMI, 64 bit x86)
  3. Download gpg (v2.3.7) and openssl (v.3.0.8) executables from the EC2 instance
  4. Download gpg lib files from EC2 instance: npth, libgpg-error, libgcrypt, libassuan, libbz2, libreadline
  5. Replace existing gpg executables with new ones
  6. Replace all downloaded lib files (pth was removed and libksba is not being included for now)
  7. Zip gpg folder and openssl executable (with zip command)
  8. Replace zips in this folder with new zips

Note: gpg-agent was not modified

rix0rrr commented 3 months ago

This update broke the custom resource because the file structure is different between the 2 zip versions.

Before

$ git checkout 25f79cb
$ unzip -l ./lib/custom-resource-handlers/layers/gpg-layer.zip
Archive:  ./lib/custom-resource-handlers/layers/gpg-layer.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
   754048  01-21-2020 01:25   gpg
   300648  01-21-2020 18:44   gpg-agent
        0  01-21-2020 18:53   lib/
    79536  01-21-2020 18:53   lib/libpth.so.20
   285232  01-21-2020 02:18   lib/libreadline.so.6
   534456  01-21-2020 02:27   lib/libgcrypt.so.11
    70832  01-21-2020 02:35   lib/libassuan.so.0
    68128  01-21-2020 02:12   lib/libbz2.so.1
    19296  01-21-2020 02:32   lib/libgpg-error.so.0

After

$ git checkout main
$ unzip -l ./lib/custom-resource-handlers/layers/gpg-layer.zip
Archive:  ./lib/custom-resource-handlers/layers/gpg-layer.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  07-18-2024 03:26   gpg-layer/
     6148  07-18-2024 03:25   gpg-layer/.DS_Store
   938568  07-18-2024 02:04   gpg-layer/gpg
   300648  01-21-2020 18:44   gpg-layer/gpg-agent
        0  07-18-2024 03:24   gpg-layer/lib/
     6148  07-18-2024 03:24   gpg-layer/lib/.DS_Store
   358304  07-18-2024 03:22   gpg-layer/lib/libreadline.so.8.1
    87040  07-18-2024 03:20   gpg-layer/lib/libassuan.so.0.8.5
    24152  07-18-2024 03:19   gpg-layer/lib/libnpth.so.0.1.2
  1331864  07-18-2024 03:18   gpg-layer/lib/libgcrypt.so.20.4.2
   153696  07-18-2024 03:19   gpg-layer/lib/libgpg-error.so.0.32.0
    81024  07-18-2024 03:24   gpg-layer/lib/libbz2.so.1.0.8
---------                     -------
  3287592                     12 files