search

cdklabs / cdk-monitoring-constructs

Easy-to-use CDK constructs for monitoring your AWS infrastructure
https://constructs.dev/packages/cdk-monitoring-constructs
Apache License 2.0
444 stars 56 forks source link

fix(elb): allow inverting load balancer task count metric statistics #387

Closed jrchen-amzn closed 11 months ago

jrchen-amzn commented 1 year ago

Summary

To monitor network load balancer metrics, track the maximum HealthyHostCount and the minimum UnHealthyHostCount as per the guidelines at https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-cloudwatch-metrics.html#metric-statistics.

Fixes #392

Tests

yarn build

The package:js build step has succeeded.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

jrchen-amzn commented 1 year ago

Hi,

I hope you are doing well. I have tested it and it works fine on my end. I would appreciate it if you could review it and merge it as soon as possible. This pull request is important for me because it solves a problem I was facing with this project.

If you need any clarification or have any feedback on this pull request, please don't hesitate to comment and let me know.

Thank you for your time and attention. 😊 krnwsn

jrchen-amzn commented 1 year ago

I appreciate your response and your insight on the breaking change. I also think it would be better to preserve the old behavior. I will make the necessary changes to the PR accordingly.

jrchen-amzn commented 1 year ago

Hi,

I'm having trouble finding a simple way to retain the old behaviour. I think I need to add the related prop(like invertStatisticsOfTaskCountEnabled) to several interfaces like BaseLoadBalancedFargateServiceMonitoringProps, NetworkLoadBalancerMetricFactoryProps, ApplicationLoadBalancerMetricFactoryProps and so on. Is there a better way to do this change?

I also opened an issue(https://github.com/cdklabs/cdk-monitoring-constructs/issues/392) for this feature request. I appreciate your advice and feedback. Thank you for your time and attention!

jrchen-amzn commented 12 months ago

Hello, I have made the changes you suggested in my pull request. Could you review it and let me know if it meets your expectations? I am grateful for your time and feedback!

jrchen-amzn commented 12 months ago

Hello @echeung-amzn , I would greatly appreciate it if you could take a moment to take a look at it and let me know if there are any issues or questions. I value your support and consideration. Thank you very much!

jrchen-amzn commented 11 months ago

I have completed the updates to the pull request. I would be grateful if you could review it at your earliest convenience. Please let me know if there are any further issues or if you require any additional information. Thank you for taking the time to review the changes:)