cdklabs / cdk-monitoring-constructs

Easy-to-use CDK constructs for monitoring your AWS infrastructure
https://constructs.dev/packages/cdk-monitoring-constructs
Apache License 2.0
465 stars 61 forks source link

[core] Enable aspects for remaining resources. #41

Open ayush987goyal opened 2 years ago

ayush987goyal commented 2 years ago

Enable scope monitoring with aspects for the following remaining resources

LarsFronius commented 2 years ago

Would be awesome to see! Is there any inherent complexity one should think about when implementing aspects for these particular resources? I assume there was a reason it's not yet implemented.

echeung-amzn commented 2 years ago

I don't believe there was a particular reason that they haven't yet been implemented, but @ayush987goyal could confirm.

ayush987goyal commented 2 years ago

So these have not been implemented because of how the underlying facade implementation of the monitoring is done. For example

LarsFronius commented 2 years ago

Thanks for the insight @ayush987goyal - that roughly matches what I had observed from glancing over it.

ayush987goyal commented 2 years ago
RichiCoder1 commented 2 years ago

I mentioned this in #120, but I'm personally very much in favor of breaking ECS down into it's component parts for monitoring and not trying to work with the L2/L3 patterns.