search

cdklabs / cdk-monitoring-constructs

Easy-to-use CDK constructs for monitoring your AWS infrastructure
https://constructs.dev/packages/cdk-monitoring-constructs
Apache License 2.0
444 stars 56 forks source link

fix(kinesis): change Provisioned Capacity Exceeded metric's Y axis label to CountAxisFromZero #419

Closed jeremy-zou closed 10 months ago

jeremy-zou commented 10 months ago

Fixes https://github.com/cdklabs/cdk-monitoring-constructs/issues/418

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

echeung-amzn commented 10 months ago

Thanks for the contribution! This also makes it clear that the naming of metricReadProvisionedThroughputExceededPercent and metricWriteProvisionedThroughputExceededPercent in KinesisDataStreamMetricFactory are incorrect.

Do you mind also:

  1. Creating new methods there (metricReadProvisionedThroughputExceeded and metricWriteProvisionedThroughputExceeded)
  2. Marking the existing methods as deprecated and just calling the new ones
  3. Updating KinesisDataStreamMonitoring to call those new methods

We can remove the old methods later as a breaking change.

jeremy-zou commented 10 months ago

Looks like you're missing the changes to API.md. You should be able to run yarn build to produce the necessary changes.

Ah yeah I see that. My bad; will fix.