feat: Keep NLB and ALB information separated to avoid check of constructor name

cdklabs / cdk-monitoring-constructs

Easy-to-use CDK constructs for monitoring your AWS infrastructure

Apache License 2.0

443 stars 56 forks source link

Closed btd closed 5 months ago

btd commented 5 months ago

Fixes #476

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

I did not updated EC2 staff, want first get some feedback

echeung-amzn commented 5 months ago

Hi, thanks for the issue report and PR! An issue with this proposed change is that it'd be a breaking API change due to the prop changes.

I've opened another PR that might be a better alternative to this: #480

Let me know if you have any thoughts!

btd commented 5 months ago

@echeung-amzn thanks. Your version is quite hacky, but yes it is not BC. So i am all for it as upgrade process will be more simple