search

cdklabs / cdk-monitoring-constructs

Easy-to-use CDK constructs for monitoring your AWS infrastructure
https://constructs.dev/packages/cdk-monitoring-constructs
Apache License 2.0
443 stars 56 forks source link

feat(UsageAlarmFactory): allow creating min/max count usage alarms without conflicting alarm names #485

Closed echeung-amzn closed 5 months ago

echeung-amzn commented 5 months ago

The existing API results in conflicts due to the identical alarmNameSuffixs.

This PR adds new replacement APIs to avoid changing existing alarm names and better aligning the interface's prop naming.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

ayush987goyal commented 5 months ago

@echeung-amzn Do we also need to update any particular resource monitoring that is using this?

echeung-amzn commented 5 months ago

Do we also need to update any particular resource monitoring that is using this?

I'd leave that for a major version bump to avoid affecting any existing alarms' naming on a minor/patch version bump by consumers.