search

cdklabs / cdk-monitoring-constructs

Easy-to-use CDK constructs for monitoring your AWS infrastructure
https://constructs.dev/packages/cdk-monitoring-constructs
Apache License 2.0
468 stars 61 forks source link

Data Table Support in GraphWidgetType #550

Open Laxenade opened 2 months ago

Laxenade commented 2 months ago

Feature scope

Custom

Describe your suggested feature

It looks like the data table type is missing from GraphWidgetType. I'm not sure if the data table is a recent widget that CW added or if there hasn't been a use case for it.

https://github.com/cdklabs/cdk-monitoring-constructs/blob/598dea1bd09df69d7d8dbc070ae9728f8629bd67/lib/common/widget/types.ts#L9-L15

It doesn't seem to be too hard to add. I can probably do a PR. I just wanted to confirm the scope first.

Laxenade commented 2 months ago

TableWidget was added in cdk-lib 5 months ago, so it's relatively recent.

https://github.com/aws/aws-cdk/commit/4599aa3c4502e5e5e5fb7434913f7ce9a6468547

echeung-amzn commented 2 months ago

Looks like we'd need to bump to minimum aws-cdk-lib@2.128.0 to get TableWidget, but we're currently at min 2.112.0. Bumping that would be a breaking change/major version bump, or temporarily maintaining a copy of it.

I'm not particularly a fan of either right now unless we wanted to bring in other new features from newer aws-cdk-lib versions too. Any thoughts from your end?

Laxenade commented 2 months ago

That's fair. I don't have a strong need for it; I was just playing around with different widgets.