search

cdklabs / cdk-verified-permissions

Amazon Verified Permissions L2 CDK Constructs
Apache License 2.0
16 stars 2 forks source link

Missing groupEntityType in IdentitySource #103

Closed mrbrianevans closed 3 months ago

mrbrianevans commented 3 months ago

Many thanks for this library! Hope it gets merged into cdk master at some point.

The construct for IdentitySource is missing props to configure the group settings.

See https://docs.aws.amazon.com/verifiedpermissions/latest/apireference/API_CognitoUserPoolConfiguration.html groupConfiguration and https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-verifiedpermissions-identitysource-cognitogroupconfiguration.html

The construct currently supports setting principalEntityType but not group.

This is what the setting looks like in the console: image

We need a prop to specify what entity type cognito groups are.

reste85 commented 3 months ago

Hey @mrbrianevans! Thanks a lot for reporting, we're working on it

reste85 commented 3 months ago

@mrbrianevans released in v0.0.1-alpha.8