search

cdklabs / construct-hub-webapp

React web app for Construct Hub
Apache License 2.0
21 stars 11 forks source link

More straightforward sorting of submodule contents #950

Open gshpychka opened 2 years ago

gshpychka commented 2 years ago

Currently, the right sidebar that displays the submodule contents doesn't sort them alphabetically. I'm actually not sure what logic it uses for the ordering. It would be much nicer if it sorted them alphabetically like the API reference.

API reference:

image

Construct Hub:

image

I have a dark theme extension, disregard.

gshpychka commented 2 years ago

Okay, I realize now that it's displaying common props/methods first (node, env, stack).

Would it be a good idea to separate them somehow to make this clearer?

Chriscbr commented 2 years ago

Would it be a good idea to separate them somehow to make this clearer?

Totally - maybe a label can be added distinguishing which are inherited and which are not. (Perhaps the inherited ones should actually go after the non-inherited ones?)

Sorting all of them together is another valid option here

gshpychka commented 2 years ago

Distinguishing them sounds more useful, but sorting them together is also okay, this is how the API reference does it.