General code cleanup - Githubissues

cdkrot / Mechanics

[old and abandoned] Mechanics Mod (Minecraft)

GNU General Public License v3.0

0 stars 1 forks source link

General code cleanup #1

Closed octylFractal closed 10 years ago

octylFractal commented 10 years ago

Moved init -> preInit as it is supposed to be there. Reworked Direction Vectors so it holds some vector instances which is more akin to how it works Formatted code

Updated to 1.7.2 EXCEPT localization need work, I can help with that if needed.

T145 commented 10 years ago

Could you please reformat some of your stuff so that:

Comments for "TODO" statements or similar do not flow across several lines
Pieces of code that have trailing commas or periods do not flow across several lines

This is mainly to avoid excess whitespace where is does not need to be and so that the code is more readable.

octylFractal commented 10 years ago

Yes, the formatting was a bit of a pain to do in the first place but I'll try to go back and see what there is to patch.

octylFractal commented 10 years ago

I need a clarification, do you not want

public List<IInventoryEX> getIInventoryAllInFor(List<Entity> entities,
            boolean isInput)

to be multi-line?

T145 commented 10 years ago

No; NO multi-line statements, only single-line ones. Single liners make for more neat code.

octylFractal commented 10 years ago

Okay. My git is weirding out on a me a bit but I think I fixed it.

octylFractal commented 10 years ago

Is this also no wrapping at 80?

octylFractal commented 10 years ago

Okay, that's all I got. Tell me anything specific I missed.

cdkrot commented 10 years ago

Thanks for moving Init->PreInit, now we have all textures working!