search

cdli-gh / cdli-mobile-app

MIT License
4 stars 8 forks source link

search bar doesn't works #19

Closed Aditi-Singh16 closed 3 years ago

Aditi-Singh16 commented 3 years ago

I searched for Montserrat, but the getdataFromAPI function returned an empty list image search screen: WhatsApp Image 2021-08-16 at 1 49 40 AM

epageperron commented 3 years ago

Hi Aditi, thanks for reporting this! Unfortunately we don't have anyone in charge of the repo at this time.

anila-a commented 3 years ago

@Aditi-Singh16 the app should be fetching only the 10 newest artifacts from the API (with pagination), that's why it doesn't show up. However, this is a temporary limitation, as soon as the new framework is published we will set up the new API link to the app.

Aditi-Singh16 commented 3 years ago

Oh okay👍🏻 Also , @anila-a actually I made a few changes in the code like

  1. flatbutton -> Textbutton
  2. Raisedbutton -> Elevated button
  3. Cach_image -> Cache network image
  4. In platform widgets Android -> material iOS -> Cupertino

So, I did these changes because there was some version conflict error and then the app build was successful But now ,when I click on the drawer , it doesn't listen to the onClick event. So what should I do now?

anila-a commented 3 years ago

Feel free to make a pull request, I'll make sure to check your contribution and help you with that issue as soon as I can :)