search

cdli-gh / cdli-mobile-app

MIT License
4 stars 8 forks source link

Fixed deprecation warnings and version conflicts #21

Open Aditi-Singh16 opened 3 years ago

Aditi-Singh16 commented 3 years ago

Changes made:

  1. FlatButton -> TextButton
  2. RaisedButton -> Elevated Button
  3. Scaffold -> ScaffoldMessenger in ScaffoldMessenger.of(context).removeCurrentSnackBar()
  4. cache image -> cache_network_image (As it was conflicting with other packages)
  5. In CarouselSlider added the attribute options
  6. In PlatformCircularProgressIndicator changed andriod ->material, ios -> cupertino
  7. Added super constructor to NavigationBloc
  8. Resolved AndroidX issues

Issue:

Unable to open drawer

NishealJ commented 3 years ago

Thankyou @Aditi-Singh16

Can you please improve the PR title & description? Also, there are changes likeflatbutton to textbutton explain that in desc too. You've upgraded a lot of libraries are they all compatible?

NishealJ commented 3 years ago

@anila-a ptal!

Aditi-Singh16 commented 3 years ago

Thankyou @Aditi-Singh16

Can you please improve the PR title & description? Also, there are changes likeflatbutton to textbutton explain that in desc too. You've upgraded a lot of libraries are they all compatible?

Yes, earlier one's were creating error, so I changed it to another version I will update the desc and title

dakshp07 commented 3 years ago

seems like I have to update my dart version before testing out your PR. Screenshot from 2021-08-19 19-12-32

Aditi-Singh16 commented 3 years ago

seems like I have to update my dart version before testing out your PR. Screenshot from 2021-08-19 19-12-32

yes mine is 2.13.4 image