search

cdli-gh / cdli-mobile-app

MIT License
4 stars 8 forks source link

Code Cleanup and change some part of code to follow Effective Dart guidelines #9

Closed MrUnfunny closed 3 years ago

MrUnfunny commented 3 years ago

Hello everyone, While going through codebase, I noticed that it deviates from Effective Dart Guidelines as suggested by dart. For example- using snake_case instead of camelCase in some places, using lowerCamelCase instead of UpperCamelCase for naming classes etc. There are also some unused imports. These leads to 30+ warnings in the codebase. I'll be more than happy to create a pull request with these changes if required. @NishealJ Please let me know.

NishealJ commented 3 years ago

@MrUnfunny Yes, there are a lot of warnings. It really required to lint the code and follow the rules.

Please feel free to create a PR, but this will require a lot of testing to make sure that you don't break an existing feature :)

MrUnfunny commented 3 years ago

Please feel free to create a PR, but this will require a lot of testing to make sure that you don't break an existing feature :)

Sure, I'll keep this in mind ;-)

kanavpruthi commented 3 years ago

Hey @NishealJ , please check this PR out, I've completed it since the issue was still open.

NishealJ commented 3 years ago

Hi @kanavpruthi there is already an open PR for this https://github.com/cdli-gh/cdli-mobile-app/pull/10

kanavpruthi commented 3 years ago

Hey @NishealJ, thanks for the reply. I thought that PR missed on something and hence wasn't merged. In this, I went a step beyond to remove all warnings apart from the dart guidelines for casing ( formatting, removing unused imports, and unused variables ). Kindly check. If you want any other changes to be made please do tell.( e.g. Refactoring )

MrUnfunny commented 3 years ago

Hey @kanavpruthi, #10 also includes removing imports, variables and formatting. The formatting caused large number of changes, maybe that's why it's taking time to review it.

kanavpruthi commented 3 years ago

Okay, no issues at all. Thanks for letting me know :)