search

cdli / CdliTwoStageSignup

Two-stage signup process for ZfcUser. Supports Zend\Db and Doctrine! Now up-to-date with latest ZfcUser (as of Oct 24th, 2012)
Other
19 stars 13 forks source link

Support for ZfcUser 1.* #18

Closed Colmea closed 9 years ago

Colmea commented 10 years ago

Hey !

Do you think it's possible to add support for zfcUser 1.* ? As more and more zf2 modules need zfcUser 1.0, it became difficult to keep my project dependencies up to date because of the old 0.* dependency.

I don't really know if zfcUser 1.0 made a lot of change which could broke your module, but maybe I could help you to have a look in the next days.

Thanks for your work !

adamlundrigan commented 10 years ago

This module didn't make it into our production app, so I haven't used it at all recently. From what I remember I don't think there is much in ZfcUser 1.* that would break this module, so if you want to check it out and report back I'll bump the requirement if everything checks out OK.

Colmea commented 10 years ago

Nice to see you're not on a parental leave for one year :p !

I've made some tests with my fork today (Colmea/CdliTwoStageSignup@72a4f87d), and it seems that everything is ok (nothing to update except dependency in composer). Mail is properly sent and sign up is possible, but didn't test any other feature.

One thing however: is it normal that composer package ref to cdli/CdliTwoStageSignup in README, and to cdli/two-stage-signup in composer.json ?

(Note: I had to go back to zfc-user 0.* because of another zf2 module which doesn't support zfx-user 1.* either, so my need to upgrade to zfc-user 1.* is not as urgent as this morning).

Colmea commented 10 years ago

Everthing seems ok for me (I'm able to sign up, receive the mail and complete the 2nd form).