search

cdmbase / graphql-rabbitmq-subscriptions

A graphql subscriptions implementation using rabbimq and apollo's graphql-subscriptions
MIT License
116 stars 27 forks source link

Questions about this implementation #10

Open nareshbhatia opened 6 years ago

nareshbhatia commented 6 years ago

I have a few questions about the usage of this implementation:

  1. Do you plan to update the graphql-subscriptions dependency to 0.5.5?
  2. The usage example in README uses SubscriptionManager, which is deprecated. Will this implementation integrate correctly with SubscriptionServer as described here.
  3. Could you please document the RabbitMQ setup - which queues, topics, exchanges are being used and how we can change them?
  4. In the app that I am building, the "publish" action will always come from the back-end microservices. It will be fired using RabbitMQ, never via http or websockets. Where should the microservices publish on RabbitMQ?
  5. I don't understand the context of the Logging example. Is this a feature that graphql-rabbitmq-subscriptions provides? Are we required to provide an implementation?
cosmin-petrescu commented 5 years ago

Still no answer for this. Do you still maintain this?

As this is a copy of graphql-redis-subscriptions, I tried to update graphql-subscriptions to ^1.0.0, but this means a full rewrite of the integration test (copy from graphql-subscriptions and adjust it).

Please give me a feedback regarding this, maybe I'll make a pull request: https://github.com/cosmin-petrescu/graphql-rabbitmq-subscriptions/commit/2559e7b42de3a0cccded9a08eb4bd7a8879473b7