cdmichaelb / Outfitter

Outfitter - Classic
MIT License
10 stars 22 forks source link

Cooking Automation not working #125

Closed Blackspectre1 closed 1 year ago

Blackspectre1 commented 1 year ago

Hi there,

I'm trying to use my Chef's Hat but the automation: "Equip while cooking window is open" isn't functioning. All my other automations work but this one doesn't. Kind of weird so I don't think it's my WTF folder or anything like that.

Regards,

Black

Kpral commented 1 year ago

Figured this one out. Go into the script source and change the following:

if event == "TRADE_SKILLSHOW" then local skillLineID, , , , _, skillLineID2 = C_TradeSkillUI.GetTradeSkillLine() if skillLineID == 185 or skillLineID2 == 185 then equip = true end elseif event == "TRADE_SKILL_CLOSE" then if didEquip then equip = false end elseif event == "TRADE_SKILLUPDATE" then local skillLineID, , , , _, skillLineID2 = C_TradeSkillUI.GetTradeSkillLine() if skillLineID == 185 or skillLineID2 == 185 then equip = true elseif didEquip then equip = false end end

to:

if event == "TRADE_SKILLSHOW" then local skillLineID, , , = GetTradeSkillLine() if skillLineID == "Cooking" then equip = true end elseif event == "TRADE_SKILL_CLOSE" then if didEquip then equip = false end elseif event == "TRADE_SKILLUPDATE" then local skillLineID, , , = GetTradeSkillLine() if skillLineID == "Cooking" then equip = true elseif didEquip then equip = false end end

Blackspectre1 commented 1 year ago

You are a genius, that worked perfectly.

Cheers,

Joel


From: Kpral @.> Sent: Friday, 6 January 2023 1:44 PM To: cdmichaelb/Outfitter @.> Cc: Blackspectre1 @.>; Author @.> Subject: Re: [cdmichaelb/Outfitter] Cooking Automation not working (Issue #125)

Figured this one out. Go into the script source and change the following:

if event == "TRADE_SKILLSHOW" then local skillLineID, , , , _, skillLineID2 = C_TradeSkillUI.GetTradeSkillLine() if skillLineID == 185 or skillLineID2 == 185 then equip = true end elseif event == "TRADE_SKILL_CLOSE" then if didEquip then equip = false end elseif event == "TRADE_SKILLUPDATE" then local skillLineID, , , , _, skillLineID2 = C_TradeSkillUI.GetTradeSkillLine() if skillLineID == 185 or skillLineID2 == 185 then equip = true elseif didEquip then equip = false end end

to:

if event == "TRADE_SKILLSHOW" then local skillLineID, , , = GetTradeSkillLine() if skillLineID == "Cooking" then equip = true end elseif event == "TRADE_SKILL_CLOSE" then if didEquip then equip = false end elseif event == "TRADE_SKILLUPDATE" then local skillLineID, , , = GetTradeSkillLine() if skillLineID == "Cooking" then equip = true elseif didEquip then equip = false end end

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcdmichaelb%2FOutfitter%2Fissues%2F125%23issuecomment-1373105822&data=05%7C01%7C%7C5f9dbd07306d4075aebf08daef9850a8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638085734725712184%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3e2UfigKWuXFy6nNg%2BPigGNFAZuolQo7O71p%2BNZ9U44%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA4ZCPWJT47SQE42RA3ALKNLWQ6IJ3ANCNFSM6AAAAAATA5CYWE&data=05%7C01%7C%7C5f9dbd07306d4075aebf08daef9850a8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638085734725712184%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=0ByGhvBZt1JDFQ%2BWl%2F3aEn%2FNcZYYvz%2FuDN7X9gfxYnc%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

Gogo1951 commented 1 year ago

Hey @Kpral , submit a PR for this! (=

Gogo1951 commented 1 year ago

I pushed this into the Alpha Channel. I can't test it myself, since I don't have the hat, but I'll leave it on Alpha for a few days and if we don't get any complaints I'll merge it into Production. Cheers!