search

cdmichaelb / Outfitter

Outfitter - Classic
MIT License
10 stars 22 forks source link

Blizzard Equipment Manager and Outfitter buttons in Character Frame overlap #139

Open b-morgan opened 1 year ago

b-morgan commented 1 year ago

When Blizzard's Equipment Manager and Outfitter are both enabled, the buttons in the PaperDollFrame overlap. Would it be possible to detect this condition and move the OutfitterButton to the left? If detecting is difficult, just move the button to the left.

I changed line 587 in Outfitter.xml:

    <AbsDimension x="-64" y="-42"/> <!-- <AbsDimension x="-28" y="-42"/> -->
GovtGeek commented 1 year ago

I'll see what I can do.

GovtGeek commented 1 year ago

I have a branch that may work for you. Can you try it? https://github.com/GovtGeek/Outfitter/releases/tag/3.0.4.6

b-morgan commented 1 year ago

I compared this 3.0.4.6 release with the 3.0.4 release and there's no code changes that would fix this issue.

GovtGeek commented 1 year ago

I'm so sorry. I pasted the wrong link. Release v3.0.4.5.2 is the one with Equipment Manager changes. The v.3.0.4.6 was a Vanilla container fix. https://github.com/GovtGeek/Outfitter/releases/tag/3.0.4.5.2

GovtGeek commented 1 year ago

@b-morgan Checking in to see if the correct update worked for you (or if you like it for that matter).

b-morgan commented 1 year ago

I've been busy and haven't tested it yet. Doing so now.

b-morgan commented 1 year ago

I compared this 3.0.4.5.2 release with the 3.0.4 release and there's no code changes that would fix this issue. Testing ingame confirmed this.

GovtGeek commented 1 year ago

Okay. One more time. I've even triple checked that the https://github.com/GovtGeek/Outfitter/releases/tag/3.0.4.5.3 release has the changes like it should and compared it to what I have installed.

I'm not sure what was happening with the packaging. I was probably up too late.