search

cdmichaelb / Outfitter

Outfitter - Classic
MIT License
10 stars 23 forks source link

Needs Hit #2

Closed Gogo1951 closed 2 years ago

Gogo1951 commented 4 years ago

Hey Guys,

Love that you've brought back Outfitter!

Especially love that you can build sets off Pawn scores!

When building a set, you can add all sorts of abilities... but it's missing hit. I feel like at some point hit was dropped from the game, and you've pulled the version of Outfitter over after those changes. Can you add hit back again?

Thanks!

cdmichaelb commented 4 years ago

Yes, that's actually my current project. Trying to get Resistances working too.

Everything seems to work using pawn weights though. Are you able to use hit in pawn?

On Tue, Jan 7, 2020 at 7:53 PM Gogo1951 notifications@github.com wrote:

Hey Guys,

Love that you've brought back Outfitter!

Especially love that you can build sets off Pawn scores!

When building a set, you can add all sorts of abilities... but it's missing hit. I feel like at some point hit was dropped from the game, and you've pulled the version of Outfitter over after those changes. Can you add hit back again?

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cdmichaelb/Outfitter/issues/2?email_source=notifications&email_token=AALCNPO7S4GJW2PPKRRU5QTQ4VE3ZA5CNFSM4KECNBDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IEU5ILA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALCNPIN7GYKJFGPR5TITSLQ4VE3ZANCNFSM4KECNBDA .

Gogo1951 commented 4 years ago

I just want to be able to say, "Build the best Pawn set that also has a hit of at least x%."

Appears I can do that with STR and such now, Pawn Weight + any other stat. It'd be great to be able to do it with hit as well.

Gogo1951 commented 4 years ago

Works great, thanks!

cdmichaelb commented 4 years ago

I just found a bug, not sure what is causing it. The resistance set generation worked on my test alt, but it's not working on my main.

Gogo1951 commented 4 years ago

Yeah it's behaving weird now. It did work the first time I used it. But now I'll add in a Pawn + Hit >= hit cap on that toon, and there's enough hit gear to get there... and it says calculating, and comes up with an outfit... but doesn't change any of the gear to meet hit conditions. Needs work. (=

Mizzajl commented 4 years ago

Rebuilding a set for melee hit does currently not seem to work. when its fixed will it take set bonuses into account? like black dragonscale set for example.

cdmichaelb commented 4 years ago

Rebuilding a set for melee hit does currently not seem to work. when its fixed will it take set bonuses into account? like black dragonscale set for example.

Yes, it should.

A work around for now is using Pawn. And personally, I think it's a better option in the first place since you can fine tune your settings.

Gogo1951 commented 4 years ago

Closing this as you have a Pawn integration that solves the issue. But... please see my other ticket around Pawn not quite working perfectly. Thanks!

Mizzajl commented 4 years ago

with pawn you can't really set a cap target for hit chance, would be really helpfull if this was possible