search

cdmichaelb / Outfitter

Outfitter - Classic
MIT License
10 stars 23 forks source link

OutfitterButton offset looks not correct #3

Closed lorem-ipsum-dolor-sit closed 2 years ago

lorem-ipsum-dolor-sit commented 4 years ago

The position from the outfitter looks a bit out of space ;)

OutfitterButton

https://github.com/cdmichaelb/Outfitter/blob/a5d65ad9f747557d84ecc0e7c0a2cf355de0d699/Outfitter.xml#L587 <AbsDimension x="-28" y="-42"/>

OutfitterFrame

https://github.com/cdmichaelb/Outfitter/blob/a5d65ad9f747557d84ecc0e7c0a2cf355de0d699/Outfitter.xml#L611 <AbsDimension x="-34" y="-48"/>

WIth my changes it looks a bit better.

cdmichaelb commented 4 years ago

It is, thanks. I suck at UI elements. Do you want to do a pull request or do you want me to just incorporate it?

On Sat, Jan 11, 2020, 5:58 AM Stefan notifications@github.com wrote:

The position from the outfitter looks a bit out of space ;)

https://user-images.githubusercontent.com/5527697/72205310-ed9aeb80-3481-11ea-9b95-7ba28f9985d3.png OutfitterButton

https://github.com/cdmichaelb/Outfitter/blob/a5d65ad9f747557d84ecc0e7c0a2cf355de0d699/Outfitter.xml#L587

OutfitterFrame

https://github.com/cdmichaelb/Outfitter/blob/a5d65ad9f747557d84ecc0e7c0a2cf355de0d699/Outfitter.xml#L611

WIth my changes it looks a bit better.

https://user-images.githubusercontent.com/5527697/72205328-18853f80-3482-11ea-85a8-75cd678f007d.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cdmichaelb/Outfitter/issues/3?email_source=notifications&email_token=AALCNPPTG7U54FEMSYPAUMLQ5HGAJA5CNFSM4KFSDX5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IFQNUPQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALCNPIDKUDX3KU2HY5HG3TQ5HGAJANCNFSM4KFSDX5A .

lorem-ipsum-dolor-sit commented 4 years ago

a pull request is pending 👍