fix download assets event

cdnjs / atom-extension

⚛ Atom extension for easily inserting scripts

https://atom.io/packages/cdnjs

MIT License

32 stars 12 forks source link

fix download assets event #10

Closed ksprwhite closed 9 years ago

ksprwhite commented 9 years ago

fix download assets event

list.find('.selected')?.view() is undefined list.find('.selected')[0].directory.path used to get selected folder path or list.find('.selected')[0].file.path to get parent folder path.

fix deprecated option 'activationEvents'

Use activationCommands instead of activationEvents in package.json. Commands should be grouped by selector

added notification on asset downloaded

atom.notifications api used to this

PeterDaveHello commented 9 years ago

cc @thomasdavis @segphault

PeterDaveHello commented 9 years ago

@ksprwhite Don't we need to add path into dependencies?

ksprwhite commented 9 years ago

I understood that it was an built-in module, I suppose that require module 'path' would be enough.

PeterDaveHello commented 9 years ago

Okay, I'm not familiar with this extension, so we should wait for @thomasdavis @segphault.

thomasdavis commented 9 years ago

Hey Jonathan, looks good. I've invited you to a team responsible for this atom plugin. Feel free to merge into master any fixes you find and I will do releases to APM.

ksprwhite commented 9 years ago

@thomasdavis okay, thanks, I'll be watching this repository.