cdnjs / new-website

🖥 cdnjs.com website
https://cdnjs.com
ISC License
451 stars 211 forks source link

Move to a better frontend framework (like React?) #166

Open imbhargav5 opened 7 years ago

imbhargav5 commented 7 years ago

The library page and search results have good behaviour and as the app grows, the imperative style code using jQuery will get out of hand and fixing one bug will break up another section of the app.

I suggest we move to React, because it's significantly light weight and it's declarative style syntax gives us modular, scoped and readable code. Thoughts? Framework suggestions are welcome!

PeterDaveHello commented 7 years ago

@bhargav175 the change could be too huge, from this on, all the contributors will need to know about react, as we don't have enough active contributors in the meantime, this could make us less contributors, and make the gap to contribute higher, I prefer not to move to react but improve the ui/ux/features under current structure :)

imbhargav5 commented 7 years ago

Makes sense. I had a feeling that would be the case. But yes, we could probably structure our code better but continue to stick with plain js and jquery. What are your thoughts on having a having a front-end build system?

On Wed 15 Mar, 2017, 12:11 PM Peter Dave Hello, notifications@github.com wrote:

@bhargav175 https://github.com/bhargav175 the change could be too huge, from this on, all the contributors will need to know about react, as we don't have enough active contributors in the meantime, this could make us less contributors, and make the gap to contribute higher, I prefer not to move to react but improve the ui/ux/features under current structure :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cdnjs/new-website/issues/166#issuecomment-286654632, or mute the thread https://github.com/notifications/unsubscribe-auth/ACzPRBcMkXdX8VpVg5iHRG2G2MdcHfIHks5rl4f8gaJpZM4MddwS .

-- Thanks, Bhargav Ponnapalli Expert mentor at Codementor.io https://www.codementor.io/bhargavponnapalli

PeterDaveHello commented 7 years ago

@bhargav175 right now, I'll prefer to focus on keep improving current codes, but I won't mind to have some tries on react or other framework. For the build system, do you mean gult or grunt?

imbhargav5 commented 7 years ago

Gulp is fine but Web pack is better. Yeah I will keep knocking the help-wanted issues out, but in parallel i will see if I can come up with a quick demo in react.

On Wed 15 Mar, 2017, 12:46 PM Peter Dave Hello, notifications@github.com wrote:

@bhargav175 https://github.com/bhargav175 right now, I'll prefer to focus on keep improving current codes, but I won't mind to have some tries on react or other framework. For the build system, do you mean gult or grunt?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cdnjs/new-website/issues/166#issuecomment-286660158, or mute the thread https://github.com/notifications/unsubscribe-auth/ACzPRHQyw4435lVttBhCIJO1R7-VFNuFks5rl5A9gaJpZM4MddwS .

-- Thanks, Bhargav Ponnapalli Expert mentor at Codementor.io https://www.codementor.io/bhargavponnapalli

qas612820704 commented 7 years ago

@imbhargav5 Hi, I have interest about this, are you in progress?

imbhargav5 commented 7 years ago

Not really. Feel free to ask the contributors and take it up if that sounds reasonable to all.

On Wed, 1 Nov 2017 at 08:46 Lego_Chiang notifications@github.com wrote:

imbhargav5 Hi, I have interest about this, are you in progress?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cdnjs/new-website/issues/166#issuecomment-340967036, or mute the thread https://github.com/notifications/unsubscribe-auth/ACzPRMrjRAftGRDLjST7UupAidWisJTGks5sx-KHgaJpZM4MddwS .

-- Thanks, Bhargav Ponnapalli Expert mentor at Codementor.io https://www.codementor.io/bhargavponnapalli

laetitiaZammit commented 6 years ago

Hi there, I'm really interested by helping on this issue. Let me know if you are interested :)