tc80
commented
4 years ago will check this out in a few mins. Just let the bot on the loose, should start fixing those inconsistent latest versions !
Closed klausenbusk closed 4 years ago
tc80
commented
4 years ago will check this out in a few mins. Just let the bot on the loose, should start fixing those inconsistent latest versions !
tc80
commented
4 years ago Sorry, looks like "few mins" was more like "few weeks"!!
For es6-promise, on disk we have all the versions, but they are not in the github repo. I see that the last publish on npm was a year ago... I think we need to have a closer look at the logic to determine the existing versions in autoupdate.
drwxr-xr-x 2 sven sven 4096 May 4 16:09 2.1.0
drwxr-xr-x 2 sven sven 4096 May 4 16:09 2.1.1
drwxr-xr-x 2 sven sven 4096 May 4 16:09 2.2.0
drwxr-xr-x 2 sven sven 4096 May 4 16:09 2.3.0
drwxr-xr-x 2 sven sven 4096 May 4 16:09 3.0.0
drwxr-xr-x 2 sven sven 4096 May 4 16:09 3.0.1
drwxr-xr-x 2 sven sven 4096 May 4 16:09 3.0.2
drwxr-xr-x 2 sven sven 4096 May 4 16:09 3.1.0
drwxr-xr-x 2 sven sven 4096 May 4 16:09 3.1.1
drwxr-xr-x 2 sven sven 4096 May 4 16:09 3.1.2
drwxr-xr-x 2 sven sven 4096 May 4 16:09 3.2.1
drwxr-xr-x 2 sven sven 4096 May 4 16:09 3.2.2
drwxr-xr-x 2 sven sven 4096 May 4 16:09 3.3.0
drwxr-xr-x 2 sven sven 4096 May 4 16:09 3.3.1
drwxr-xr-x 2 sven sven 4096 May 4 16:09 4.0.0
drwxr-xr-x 2 sven sven 4096 May 4 16:09 4.0.1
drwxr-xr-x 2 sven sven 4096 May 4 16:09 4.0.2
drwxr-xr-x 2 sven sven 4096 May 4 16:09 4.0.4
drwxr-xr-x 2 sven sven 4096 May 4 16:09 4.0.5
drwxr-xr-x 2 sven sven 4096 May 4 16:09 4.1.0
drwxr-xr-x 2 sven sven 4096 May 4 16:09 4.1.1
drwxr-xr-x 2 sven sven 4096 Jun 3 11:31 4.2.0
drwxr-xr-x 2 sven sven 4096 Jun 3 11:31 4.2.1
drwxr-xr-x 2 sven sven 4096 Jun 3 11:31 4.2.2
drwxr-xr-x 2 sven sven 4096 Jun 3 11:31 4.2.3
drwxr-xr-x 2 sven sven 4096 Jun 3 11:31 4.2.4
drwxr-xr-x 2 sven sven 4096 Jun 3 11:31 4.2.5
drwxr-xr-x 2 sven sven 4096 Jun 3 11:31 4.2.6
drwxr-xr-x 2 sven sven 4096 Jun 3 11:31 4.2.7
drwxr-xr-x 2 sven sven 4096 Jun 3 11:31 4.2.8
-rw-r--r-- 1 sven sven 651 Jul 11 19:23 package.json
drwxr-xr-x 2 sven sven 4096 Jun 29 19:56 v4.2.3
klausenbusk
commented
4 years ago Are the directories empty? I have seen that behavior before.
tc80
commented
4 years ago @klausenbusk yep empty, so git will not care about them 😢
MattIPv4
commented
4 years ago I think the bot was fixed of this bug (it was trying to add versions when no files were matched). Maybe the local cdnjs/cdnjs clone just needs cleaning up (all empty directories being removed?)
klausenbusk
commented
4 years ago I think the bot was fixed of this bug (it was trying to add versions when no files were matched). Maybe the local cdnjs/cdnjs clone just needs cleaning up (all empty directories being removed?)
The code is broken. The code check if the directory exists, but don't delete it if no files matched. I will open a PR shortly.
MattIPv4
commented
4 years ago I wouldn't say that broken really, empty directories should never exist and are the result of a previous bug?
klausenbusk
commented
4 years ago and are the result of a previous bug?
They are the result of a broken autoupdate config. We shouldn't create a directory if we have no files to copy.
MattIPv4
commented
4 years ago That was the previous bug that I believe was patched, unless I'm going mad -- we should no longer be creating directories if no files match
klausenbusk
commented
4 years ago That was the previous bug that I believe was patched, unless I'm going mad -- we should no longer be creating directories if no files match
I don't think it was. See PR: https://github.com/cdnjs/tools/pull/139
klausenbusk
commented
4 years ago With cdnjs/tools#139 merged, could you (@tc80) delete all the empty directories? (find . -type d -empty -delete)
tc80
commented
4 years ago Thanks for following up, yep! Will clean and comment here when done
tc80
commented
4 years ago @klausenbusk ran git clean -d -f
After:
tcaslin@cdnjs-bot-6:/cdnjs-sven/cdnjs/ajax/libs$ git ls-files . --exclude-standard --others -m
tcaslin@cdnjs-bot-6:/cdnjs-sven/cdnjs/ajax/libs$ Does this seem correct?
tc80
commented
4 years ago Ran find . -type d -empty -delete to remove git-ignored empty directories.
After:
tcaslin@cdnjs-bot-6:/cdnjs-sven/cdnjs/ajax/libs$ sudo find . -type d -empty
tcaslin@cdnjs-bot-6:/cdnjs-sven/cdnjs/ajax/libs$ Autoupdate is redeployed and running. Reopen this if you see any strange behavior @klausenbusk .
klausenbusk
commented
4 years ago I haven't checked all the packages, but TypewriterJS and canvg hasn't updated (yet?)
TypewriterJS (PR: #314) (cdnjs repo) canvg (PR: #318) (cdnjs repo)
tc80
commented
4 years ago Strange, will look into it. On disk there is just 1.0.0. But show-files says:
tcaslin@cdnjs-bot-6:/cdnjs-sven/cdnjs/ajax/libs/TypewriterJS$ /usr/local/bin/checker -no-path-validation show-files $BOT_BASE_PATH/packages/packages/t/TypewriterJS.json
Running in debug mode
/cdnjs-sven/packages/packages/t/TypewriterJS.json: download https://registry.npmjs.org/typewriter-effect/-/typewriter-effect-2.13.1.tgz in /tmp/npmtarball543467677
most recent version: 2.13.1
/cdnjs-sven/packages/packages/t/TypewriterJS.json: download https://registry.npmjs.org/typewriter-effect/-/typewriter-effect-2.13.1.tgz in /tmp/npmtarball781645144
core.js react.js
::error file=/cdnjs-sven/packages/packages/t/TypewriterJS.json,line=1,col=1::Filename `typewriter.min.js` not found in most recent version `2.13.1`.%0A
9 last version(s):
/cdnjs-sven/packages/packages/t/TypewriterJS.json: download https://registry.npmjs.org/typewriter-effect/-/typewriter-effect-2.13.0.tgz in /tmp/npmtarball252712663
- 2.13.0: 2 file(s) matched :heavy_check_mark:
/cdnjs-sven/packages/packages/t/TypewriterJS.json: download https://registry.npmjs.org/typewriter-effect/-/typewriter-effect-2.12.2.tgz in /tmp/npmtarball505349194
- 2.12.2: 2 file(s) matched :heavy_check_mark:
/cdnjs-sven/packages/packages/t/TypewriterJS.json: download https://registry.npmjs.org/typewriter-effect/-/typewriter-effect-2.12.1.tgz in /tmp/npmtarball165593377
- 2.12.1: 2 file(s) matched :heavy_check_mark:
/cdnjs-sven/packages/packages/t/TypewriterJS.json: download https://registry.npmjs.org/typewriter-effect/-/typewriter-effect-2.12.0.tgz in /tmp/npmtarball256634892
- 2.12.0: 2 file(s) matched :heavy_check_mark:
/cdnjs-sven/packages/packages/t/TypewriterJS.json: download https://registry.npmjs.org/typewriter-effect/-/typewriter-effect-2.11.0.tgz in /tmp/npmtarball055217659
- 2.11.0: 2 file(s) matched :heavy_check_mark:
/cdnjs-sven/packages/packages/t/TypewriterJS.json: download https://registry.npmjs.org/typewriter-effect/-/typewriter-effect-2.10.0.tgz in /tmp/npmtarball096151326
- 2.10.0: 2 file(s) matched :heavy_check_mark:
/cdnjs-sven/packages/packages/t/TypewriterJS.json: download https://registry.npmjs.org/typewriter-effect/-/typewriter-effect-2.9.0.tgz in /tmp/npmtarball472996837
- 2.9.0: 2 file(s) matched :heavy_check_mark:
/cdnjs-sven/packages/packages/t/TypewriterJS.json: download https://registry.npmjs.org/typewriter-effect/-/typewriter-effect-2.8.2.tgz in /tmp/npmtarball158515200
- 2.8.2: 2 file(s) matched :heavy_check_mark:
/cdnjs-sven/packages/packages/t/TypewriterJS.json: download https://registry.npmjs.org/typewriter-effect/-/typewriter-effect-2.8.1.tgz in /tmp/npmtarball009823583
- 2.8.1: 2 file(s) matched :heavy_check_mark:Ah. package.json says latest version is 2.13.1. But still this shouldn't affect downloading new packages....
{"authors":[{"name":"Tameem Safi","email":"@tameemsafi","url":"https://safi.me.uk/"}],"autoupdate":{"source":"npm","target":"typewriter-effect","fileMap":[{"basePath":"dist","files":["*.js"]}]},"description":"A native javascript plugin that can be used to create an elegent automatic typewriter animation effect on websites.","filename":"typewriter.min.js","homepage":"https://safi.me.uk/typewriterjs/","keywords":["typewriter","effect","plugin"],"license":"MIT","name":"TypewriterJS","repository":{"type":"git","url":"git://github.com/tameemsafi/typewriterjs"},"version":"2.13.1","author":"Tameem Safi <@tameemsafi> (https://safi.me.uk/)"}@klausenbusk found the problem
We are ignoring it. Will try to fix 👍
2020-07-30T16:10:51Z Jul 30 16:10:51 cdnjs-bot-6 autoupdate[11622]: 2020/07/30 16:10:51 t/TypewriterJS.json: running npm update A
2020-07-30T16:10:51Z Jul 30 16:10:51 cdnjs-bot-6 autoupdate[11622]: 2020/07/30 16:10:51 t/TypewriterJS.json: run /usr/local/bin/git ls-tree --name-only origin/master /cdnjs-sven/cdnjs/ajax/libs/TypewriterJS/1.0.0 from /cdnjs-sven/cdnjs/ajax/libs/TypewriterJS A
2020-07-30T16:10:51Z Jul 30 16:10:51 cdnjs-bot-6 autoupdate[11622]: 2020/07/30 16:10:51 t/TypewriterJS.json: found 1 staged versions A
2020-07-30T16:10:51Z Jul 30 16:10:51 cdnjs-bot-6 autoupdate[11622]: 2020/07/30 16:10:51 t/TypewriterJS.json: existing npm versions: [1.0.0] A
2020-07-30T16:10:52Z Jul 30 16:10:52 cdnjs-bot-6 autoupdate[11622]: 2020/07/30 16:10:52 t/TypewriterJS.json: existing version not found on npm: 1.0.0 A
2020-07-30T16:10:52Z Jul 30 16:10:52 cdnjs-bot-6 autoupdate[11622]: 2020/07/30 16:10:52 t/TypewriterJS.json: ignoring misconfigured npm package: %!s(*string=0xc002945790) A
2020-07-30T19:00:23Z Jul 30 19:00:23 cdnjs-bot-6 update-website.sh[31590]: 2020/07/30 19:00:23 /cdnjs-sven/cdnjs/ajax/libs/TypewriterJS/package.json: OK A
2020-07-30T19:06:37Z Jul 30 19:06:37 cdnjs-bot-6 update-website.sh[31590]: TypewriterJS: Ok A Same for canvg:
A 2020-07-30T19:18:41Z Jul 30 19:18:41 cdnjs-bot-6 autoupdate[28557]: 2020/07/30 19:18:41 c/canvg.json: running npm update
A 2020-07-30T19:18:41Z Jul 30 19:18:41 cdnjs-bot-6 autoupdate[28557]: 2020/07/30 19:18:41 c/canvg.json: run /usr/local/bin/git ls-tree --name-only origin/master /cdnjs-sven/cdnjs/ajax/libs/canvg/1.0 /cdnjs-sven/cdnjs/ajax/libs/canvg/1.1 /cdnjs-sven/cdnjs/ajax/libs/canvg/1.2 /cdnjs-sven/cdnjs/ajax/libs/canvg/1.3 /cdnjs-sven/cdnjs/ajax/libs/canvg/1.4 /cdnjs-sven/cdnjs/ajax/libs/canvg/1.5 from /cdnjs-sven/cdnjs/ajax/libs/canvg
A 2020-07-30T19:18:41Z Jul 30 19:18:41 cdnjs-bot-6 autoupdate[28557]: 2020/07/30 19:18:41 c/canvg.json: found 6 staged versions
A 2020-07-30T19:18:41Z Jul 30 19:18:41 cdnjs-bot-6 autoupdate[28557]: 2020/07/30 19:18:41 c/canvg.json: existing npm versions: [1.0 1.1 1.2 1.3 1.4 1.5]
A 2020-07-30T19:18:42Z Jul 30 19:18:42 cdnjs-bot-6 autoupdate[28557]: 2020/07/30 19:18:42 c/canvg.json: existing version not found on npm: 1.0
A 2020-07-30T19:18:42Z Jul 30 19:18:42 cdnjs-bot-6 autoupdate[28557]: 2020/07/30 19:18:42 c/canvg.json: existing version not found on npm: 1.1
A 2020-07-30T19:18:42Z Jul 30 19:18:42 cdnjs-bot-6 autoupdate[28557]: 2020/07/30 19:18:42 c/canvg.json: existing version not found on npm: 1.2
A 2020-07-30T19:18:42Z Jul 30 19:18:42 cdnjs-bot-6 autoupdate[28557]: 2020/07/30 19:18:42 c/canvg.json: existing version not found on npm: 1.3
A 2020-07-30T19:18:42Z Jul 30 19:18:42 cdnjs-bot-6 autoupdate[28557]: 2020/07/30 19:18:42 c/canvg.json: existing version not found on npm: 1.4
A 2020-07-30T19:18:42Z Jul 30 19:18:42 cdnjs-bot-6 autoupdate[28557]: 2020/07/30 19:18:42 c/canvg.json: existing version not found on npm: 1.5
A 2020-07-30T19:18:42Z Jul 30 19:18:42 cdnjs-bot-6 autoupdate[28557]: 2020/07/30 19:18:42 c/canvg.json: ignoring misconfigured npm package: %!s(*string=0xc00178b150) @xtuc should we remove this check or should we decide on these packages on a per-package basis?
tc80
commented
4 years ago Deployed change, and it just updated canvg, so I think we are good here 👍
@klausenbusk feel free to reopen this if you see anything strange! Thanks again for monitoring cdnjs so closely, you're awesome! 😄
As part of #302 I did open a few PRs:
Looking at the cdnjs repo, new versions has only been added for the
atmospherepackage. Why aren't the other packages updating? :)