cdnjs / tutorials

📖 Community driven web development tutorials
MIT License
215 stars 124 forks source link

Updates Model tutorial so that validation works #19

Closed chadchabot closed 2 years ago

chadchabot commented 8 years ago

Why:

This change addresses the need by:

Side effects of this change:

Issue link:

PeterDaveHello commented 8 years ago

I'll respectfully suggest you to move the fix of trailing white space to a separate commit next time, to have a better commit log, thanks.

PeterDaveHello commented 8 years ago

@thomasdavis @dcki @pdcamilleri guys would you like to have a quick review on this PR? Thanks!

dcki commented 8 years ago

Sorry but TBH my last experience attempting to contribute to this project was very poor. Have you added any kind of guidelines for contributors? Until then, I'm staying out of this.

chadchabot commented 8 years ago

Not a problem @PeterDaveHello. I had initially kept them as separate commits, but merged for brevity.

I've separated them and will resubmit.

PeterDaveHello commented 8 years ago

@dcki sorry not. @chadchabot sorry that I don't use that lib, it'll take more time to merge, I'll need some other contributors to help me review this change, do you know anyone else can help? Thanks.

dcki commented 8 years ago

Sorry for all the stuff I've been saying. The truth is I still have very little experience with open source collaboration. While I'm surprised with the way things work, I shouldn't be so quick to be critical given that I am so inexperienced.