search

cdonovick / peak

Peak : Processor Specification Language ala Newell and Bell's ISP
19 stars 3 forks source link

Fault poke protocol #156

Closed leonardt closed 4 years ago

leonardt commented 4 years ago

Depends on https://github.com/leonardt/fault/pull/235

Adds support for poking with a magma protocol value.

One option for addressing https://github.com/cdonovick/peak/issues/154

The other option is to have the user explicitly convert it into a Bits representation before poking with fault, which is how the op is poked using tester.circuit.op = int(asm.assemble(op))

cdonovick commented 4 years ago

Maybe rebase this on master? Seems like CI is failing on a bad import that should not exist anymore.

leonardt commented 4 years ago

Yea this was based on fault-tuple-bug (had to create a new branch so I could render the diff), but i'm not sure what the plan for getting that branch up to date is because it seems to be out of sync. Perhaps @jack-melchert can get fault-tuple-bug up to date with master and submit a PR? This was mainly just to show the required code changes for the fault support.

leonardt commented 4 years ago

I think we can close this for now, it's quite stale but let me know if there's any issues related to this that I can help out with. I think we're able to use fault to poke the required values for the tests needed?