search

cdonovick / peak

Peak : Processor Specification Language ala Newell and Bell's ISP
19 stars 3 forks source link

TaggedUnion support and is_valid #181

Closed cdonovick closed 4 years ago

cdonovick commented 4 years ago

The use of opcode kinda just spread from _gen_is_valid where it make sense because it deals with enums and sum tags. In most cases it might be better named instruction_bv but that seems wordy. A name that might seem reasonable is assembled_inst but that creates confusion with asm_adt. So I think its reasonable - opcode means the argument must be a bitvector.

cdonovick commented 4 years ago

But if you want it changed I can

rdaly525 commented 4 years ago

Does not particularly matter.