search

cdornan / fmt

New formatting library
BSD 3-Clause "New" or "Revised" License
56 stars 6 forks source link

0 of unsigned type is printed incorrectly #31

Closed gromakovsky closed 3 years ago

gromakovsky commented 4 years ago

Run stack repl in a fresh clone of this repo:

ghci> pretty (0 :: Word) :: String
"-0"

That's a known problem in formatting that's resolved in this PR: https://github.com/chrisdone/formatting/pull/61/files. However, formatting is not maintained anymore, but is still used as a dependency. As a long term solution I think this dependency should be removed somehow, but in short term it would be nice to fix formatting of unsigned numbers at least.

gromakovsky commented 4 years ago

formatting got a maintainer and this issue was fixed there. So updating formatting dependency should fix the problem.

cdornan commented 3 years ago

Fixed in formatting-7.0.0 — the cabal lower bounds have been adjusted accordingly.