cdot65 / pan-os-upgrade

An efficient tool to execute configuration backups, network state snapshots, system readiness checks, and operating system upgrades of Palo Alto Networks firewalls and Panorama appliances.
https://cdot65.github.io/pan-os-upgrade/
Apache License 2.0
43 stars 9 forks source link

96 post upgrade snapshot and report generation skipped for firewalls #97

Closed cdot65 closed 9 months ago

cdot65 commented 9 months ago

Checklist for This Pull Request

🚨Please adhere to the guidelines for contributing to this repository.

Pull Request Description

This pull request addresses a critical bug identified in the post-upgrade process of the firewall upgrade script. Previously, the generation of post-upgrade snapshots and diff reports was skipped if a settings.yaml file was not present in the working directory. This pull request ensures that these crucial steps are executed regardless of the settings.yaml presence, thus guaranteeing the availability of post-upgrade snapshots and reports for every upgrade.

What does this pull request accomplish?

Are there any breaking changes included?

Is there anything the reviewers should know?

This pull request introduces changes that ensure post-upgrade steps are executed consistently, enhancing the reliability and traceability of firewall upgrades. It is a vital fix to ensure that upgrades' effects can be thoroughly reviewed and verified.

Related Issue: Describes a bug where post-upgrade snapshots and diff reports were skipped if settings.yaml was not found. This PR ensures these steps are always executed to maintain upgrade integrity.

Commits Included:

Thank you for your contributions!