cdp-ucsc / doc

0 stars 0 forks source link

15 update sql style guide with sqlfluff rulesnotes #17

Closed jtomkins closed 1 year ago

jtomkins commented 1 year ago

Description & motivation:

Enhancements to UCSC Style guide and SQLFluff upgrade included more rules we are interested in linting and fixing. Changes to Sql Style Guide to include the corresponding sqlfluff rules New SQLFluff documentation to include sql style guide rules

To-do before merge:

n/a

Screenshots:

n/a

References or links:

issue #4, #15, and https://github.com/cdp-ucsc/dbt-pilot/issues/66, https://github.com/cdp-ucsc/dbt-pilot/issues/102

Validation of models:

n/a

Checklist:


insuhpak commented 1 year ago

Hi Jen looks great!! Love the inline reference to the sqlfluff rule code it is so convenient.

I was able to see the changes really clearly by building a local site off of the PR branch. FYI, something I noticed is that the current version of the website looks like this (notice the left sidebar) image

And when I build this PR branch locally the website looks like this image

So I actually merged main into this PR branch (just locally for me) to see what the site would actually look like with this PR's changes image

Doesn't impact this PR but wanted to mention it for others.