Expose Battery_soc reserve, to enable Timed Export and Discharge

[reidjr]

Without setting battery_soc_reserve to less than 100, then on my inverter, the battery does not discharge in timed discharge or export. The givenergy-modbus set_mode_storage sets a default set_shallow_charge = 100, which then sets battery_soc_reserve = 100.

These changes add battery soc reserve slider to timed discharge and timed export services, and expose set_shallow_charge as a number, and as a slider control.

These changes break the logic to determine battery mode, but if you ignore the soc value check, I think the logic still works.

[cdpuk]

Thanks for your contribution. I think there's a few things going on here so I'm going to suggest we break this up.

• Exposing battery_soc_reserve via the number platform is definitely the right thing to do. This mirrors how you'd change it via the portal or app as a standalone setting.
• I'm less keen on adding this to the service calls for a couple of reasons:
  • It forces users to specify a value, even if they'd rather not change the value of battery_soc_reserve.
  • It's inconsistent with the GivEnergy portal. On the Settings tab, you'll notice battery_soc_reserve only appears under the "Battery Options" section. The services were modelled after these screens for familiarity.
• More investigation is required around your inverter behaviour, because mine is certainly fine discharging with battery_soc_reserve set to 100. For me, changing battery_soc_reserve has no effect. Buried in the app documentation it suggets this setting is only effective when an EPS system is connected.
• On further digging it also look like client.set_mode_storage is setting the value for battery_soc_reserve to 100, but that's inconsistent with the GivEnergy portal, which maintains any existing value as the user switches between modes. The proposed change then has to make another call to change the value again. The integration probably needs to bypass client.set_mode_storage and change settings directly to have the right effect.

That's quite a lot to think about. TLDR:

• Let's do a PR for just the number.py changes first.
• Are you using an EPS? That would explain why battery_soc_reserve is doing something for you.

[reidjr]

I see from several of the comments this may be down to different behaviour between Gen1 Gen2 or firmware versions. This may also mean the suggested "Clarifications" of the descriptions for the services are wrong for other people.

To try to answer in order :-).

No problem, and thanks to you for the excellent integration.

• Exposing by a number - Check
• I understand completely, see comment on 4th point.
• I should have said. My inverter is HY5.0 Gen2 on firmware D0.906-A0.906. How do you set the minimum discharge SoC on your Gen1? I can confirm that the value of that register in my inverter seems to set the point at which the Battery stops discharging. Also using the app, the only control available is that slider, which controls battery_soc_reserve. I wasn't clear if it was perhaps battery_discharge_min_power_reserve, having read the givenergy-modbus docs. ( just went back to check somthing, and they seem offline ...). But confirmed with your debug script that the value that changes, and changes the discharge point on MY inverter is indeed battery_soc_reserve.
• "Bypass client.set_mode_storage" is more elegant. I had to expose the values on the service calls to override defaults actively set by the call, as you say, so had to be part of the service. Very happy to do further testing, just tell me what you need.