cdpuk / givenergy-local

Home Assistant integration for local access to GivEnergy inverter and battery systems
MIT License
50 stars 14 forks source link

Add Battery Model based on design capacity #8

Closed cpaius closed 2 years ago

cpaius commented 2 years ago

Updated the battery module in Device Info. The Model defaults to GivBat and the model is derived from battery designed capacity.

cdpuk commented 2 years ago

I was just tweaking a couple of things - what does your 5.2 battery show for battery_design_capacity and battery_design_capacity_2 (before truncation or rounding)?

My 8.2 shows 158.72 and 160.0 respectively. The latter value matches the datasheet, which would make it easier to predict values for unknown models. The 5.2 datasheet shows 102Ah - I'm hoping that's what you see for battery_design_capacity_2.

cpaius commented 2 years ago

I also an an 8.2 which shows 158.72 and 160.0. I added the 5.2 model based on the value for battery_design _capacity I saw in another fork of your project @lexathon.
See fork diff here

cdpuk commented 2 years ago

Ah, well spotted. I'll make some guesses based on the datasheets for now and see what people say. Thanks.