cdpuk / ha-bestway

Home Assistant integration for Bestway / Lay-Z-Spa hot tubs
MIT License
63 stars 16 forks source link

Using climate.set_temperature to set temp and mode doesn't work #13

Closed jak119 closed 1 year ago

jak119 commented 1 year ago

If I use climate.set_temperature when the climate entity is off will only set the temp but not do anything with the hvac_mode. The behavior I'd expect from this call is to set the temp to 100º and set the entity to heat. This is how other integrations (e.g., Ecobee) work.

Example service call

service: climate.set_temperature
data:
  temperature: 100
  hvac_mode: heat
target:
  entity_id: climate.spa_thermostat
cdpuk commented 1 year ago

This is true since the user docs suggest that hvac_mode should be respected.

Looks like a relatively straightforward change to make but if I'm to do this it's going to be a couple more months until my spa in unpacked again for summer and available for testing.

The workaround for now is to explicitly call climate.set_hvac_mode.

jak119 commented 1 year ago

it's going to be a couple more months until my spa in unpacked again for summer and available for testing.

I agree, looks like a simple change. Mine is out and I'm willing to test. If you have a pre-release version you want me to try out ahead of time I'd be happy to. No rush though, I'm using the workaround in the meantime and appreciate you having taken the time to write this.