search

cdqa-suite / cdQA

⛔ [NOT MAINTAINED] An End-To-End Closed Domain Question Answering System.
https://cdqa-suite.github.io/cdQA-website/
Apache License 2.0
614 stars 191 forks source link

Fix Documentation: #329

Closed rsjain1978 closed 4 years ago

rsjain1978 commented 4 years ago

Code samples in generate_squad_examples() and df2squad() methods are referring to incorrect package name. For e.g.

from cdqa.utils.converter import generate_squad_examples & from cdqa.utils.converter import df2squad, filter_paragraphs

These have been fixed with the right package name.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5d2e4b3). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #329   +/-   ##
=========================================
  Coverage          ?   67.69%           
=========================================
  Files             ?       12           
  Lines             ?     1269           
  Branches          ?        0           
=========================================
  Hits              ?      859           
  Misses            ?      410           
  Partials          ?        0
Impacted Files Coverage Δ
cdqa/utils/converters.py 78.64% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d2e4b3...10cc3e8. Read the comment docs.

fmikaelian commented 4 years ago

Thank you for contributing @rsjain1978 !