On the file retriever_sklearn.py the docstring of the class BM25Retriever states that the default value of the parameter _mindf is 1
min_df : float in range [0.0, 1.0] or int
When building the vocabulary ignore terms that have a document frequency
strictly lower than the given threshold. This value is also called cut-off
in the literature. If float, the parameter represents a proportion of
documents, integer absolute counts. This parameter is ignored if vocabulary
is not None. (default is 1)
On the file retriever_sklearn.py the docstring of the class BM25Retriever states that the default value of the parameter _mindf is 1
However it is set to 2
Shouldn't the value be 1, as the docstring states ? or should the docstring be updated ? I personally get better results the value as 1.
I can create a pull request with either of the solutions.
Thanks team.