search

cdrdao / cdrdao

GNU General Public License v2.0
54 stars 21 forks source link

Readiness of release 1.2.5 #15

Closed CrateDepth closed 1 year ago

CrateDepth commented 1 year ago

Multiple "tiny" things related to this query which I am raising...

I am interested in gcdmaster. As per Issue #3 I assume that it is now only compilable with GTK3? (Note: I am aware of at least one or two GTK apps which still need GTK2). If GTK3 is necessary, then it looks like release 1.2.5 is needed.

How quickly can 1.2.5 be made OPENLY available as a compressed tar file? This is currently the situation with 1.2.4.

Is there currently stuff left to do before 1.2.5 is released? If so, what?

Ideally, I would like to have a workable gcdmaster in the next version of Debian Linux 12 (Bookworm). However, given how cdrdao is "used" in Debian, the deadline is either in 1 to 3 weeks time or the deadline has been missed.

Sorry for the vagueness of the query which I am raising. I have only really just started learning about the Debian package creation process together with Debian's strict deadlines. Therefore, the questions I have or will ask may have a lot of flex in them.

denisleroy commented 1 year ago

Hi there,

The current dev branch is I believe pretty much ready for 1.2.5. If you have a chance to test it out, I'd appreciate any feedback.

There is a "basic" gtk3 port merged in (port by steffanroellin), although it keeps the visual aspect of gcdmaster similar to the old gtk2 version. There is a gtk3 branch that I worked on at some point, which is a more inline with the GTK-3 ways of things, but it's not entirely complete, and I don't have time to finish it at this point.

Some of the possible missing things that I had in mind to release dev as 1.2.5 was the UTF-8 toc support added in 1.2.5 which I think required some tweaks in toc2mp3, but this is pretty minor and doesn't break things by default.

CrateDepth commented 1 year ago

Summarising what you wrote above, it looks like there are two things:

  1. UTF-8: You want to quickly add in UTF-8 toc support to 1.2.5. I assume that would just take one evening. I don't know which evening you'll do that on :-)
  2. Testing: You want testing done independent of @steffanroellin. I have a relatively old build environment and I don't know whether it is suitable for compiling cdrdao/gcdmaster. Having said that, I am running a GTK3 GUI right now.

Therefore, you want both of the above to be done before release 1.2.5 goes out?

alex-free commented 1 year ago

Summarising what you wrote above, it looks like there are two things:

1. UTF-8: You want to quickly add in UTF-8 toc support to 1.2.5.  I assume that would just take one evening.  I don't know which evening you'll do that on :-)

2. Testing: You want testing done independent of @steffanroellin.  I have a relatively old build environment and I don't know whether it is suitable for compiling cdrdao/gcdmaster.  Having said that, I am running a GTK3 GUI right now.

Therefore, you want both of the above to be done before release 1.2.5 goes out?

I hope this bug fix gets in 1.2.5. https://github.com/cdrdao/cdrdao/pull/14

denisleroy commented 1 year ago

The UTF-8 support is already in dev and reasonably well tested. I have some french CDs with diacritics in track names and those are now handled correctly. It was more complicated than that, the CD-R format has some support for it which wasn't handled correctly by the TOC format.

I'm sorry I didn't have time to look at #14, I'll do that within the next few days.

CrateDepth commented 1 year ago

Firstly, thank you to @denisleroy for releasing cdrdao 1.2.5. Currently, Debian's Status Tracker for cdrdao at [https://tracker.debian.org/pkg/cdrdao] acknowledges that there is a new tar.bz2 file ready for packaging.

However, cdrdao 1.2.5 will not be part of Debian 12 (Bookworm) main/stable distribution.

There is a deadline of Sun 12th Feb for which the cdrdao package needs to reach the current testing distribution. Before that, it needs to have been in the current unstable distribution for probably 10 days. Even before that, the package would need to prepared (if it were me, not being experienced at Debian packaging, it would take time as it looks like there is a lot to do for this such as PACKAGE test building) and then a Debian sponsor/mentor would need to review that the prepared package is fine (which means finding and then waiting for a suitably experienced Debian volunteer's "free time"), etc...

A small part of the problem is there is no single person designated as a Maintainer of the cdrdao package. The last time the package had a single person Maintainer was officially in 2013!

The Debian QA team are designated as the Maintainer. Therefore, cdrdao will only get packaged when resource is available. cdrdao was last packaged in May 2022.

A cdrdao 1.2.5 for Bookworm could be created as part of the stable-backport distribution/repository, for which a Debian Bookworm user would need to "opt-in". However, if I understand things correctly, the opportunity for that to occur will only be after Bookworm is released (i.e. this summer earliest).