search

cdrx / docker-pyinstaller

PyInstaller for Linux and Windows inside Docker
MIT License
618 stars 241 forks source link

Use pyinstaller version 3.5 #62

Closed Enteee closed 5 years ago

Enteee commented 5 years ago

Note: I did not bump the version of the container built in the win32/ directory. The reason for this is that those are using pyinstaller 3.3, instead of 3.4, and I am not quite sure why and if this is a needed dependency.

Enteee commented 5 years ago

I did create a preview build for the windows container here.

Enteee commented 5 years ago

Using the new pyinstaller version I now see the following issue: https://github.com/pyinstaller/pyinstaller/issues/3733

cdrx commented 5 years ago

I think the migration to v3.5 was covered in #60

Enteee commented 5 years ago

yep, thx. He also didn't migrate the win32/ directory. Do you know the reason for this?

cdrx commented 5 years ago

Because it wasn't on the same version; not sure why. It should probably all be the same version of PyInstaller.

Enteee commented 5 years ago

@cdrx yeah I was thinking that too. I didn't bump it because I don't have a test-case for it. But maybe this should be a pr as well?

cdrx commented 5 years ago

Yep! If you create that PR I'll merge it

Enteee commented 5 years ago

@cdrx sorry but i don't think i should be the one opening the pull request. As I said I don't have the means to test it.

cdrx commented 5 years ago

No problem