search

cdrx / docker-pyinstaller

PyInstaller for Linux and Windows inside Docker
MIT License
616 stars 238 forks source link

Provide versioned tags of previous images #85

Open Lindenk opened 4 years ago

Lindenk commented 4 years ago

The latest version of pyinstaller seems to have an issue running built executables on windows 7 and 10 (https://github.com/pyinstaller/pyinstaller/issues/4510). While this issue is rather fringe, it's caused a breaking change for me and I can't roll back to an earier image or specify a image version because they aren't tagged.

So, would you mind if I submitted a pull request to apply a version number to images built and uploaded to docker hub? In the meantime I'll need to fork and build my own version of this build image.

Lindenk commented 4 years ago

Scratch that I just realized the building/tagging script isn't part of this repository. Maybe we can set up CI?

Lindenk commented 4 years ago

More specficially, I (presumably) either need python updated to 3.8 or to build this image at commit cccdf6c1c545f146f9f1273451ffbbf9f124cf73 to workaround the issue.