MOC load error on MOCs with complicated perimeters

cds-astro / aladin-lite

An astronomical HiPS visualizer in the browser

https://aladin.cds.unistra.fr/AladinLite/

GNU General Public License v3.0

99 stars 41 forks source link

MOC load error on MOCs with complicated perimeters #150

Closed ManonMarchand closed 3 months ago

ManonMarchand commented 6 months ago

Since v3.3.0, I have the following error when calling MOCFromJSON:

MOC load error:Error: recursive use of an object detected which would lead to unsafe aliasing in rust

On MOCs with complicated perimeters. See for example this MOC moc.zip that triggers the error.

ManonMarchand commented 5 months ago

Note: It was working with version 3.2

bmatthieu3 commented 4 months ago

https://github.com/cds-astro/cds-moc-rust/pull/8 should fix that again and keep the ability to render a MOC perimeter (not only full cells as it was the case in previous versions)

bmatthieu3 commented 3 months ago

@ManonMarchand - the moc you give now works in develop so I can close the issue. There are some rendering artifacts as I do not subdivide enough some cells but I think this is for another improvement issue.